fix(confluent-kafka): use PUBLISH operation for producer spans#4435
Closed
alliasgher wants to merge 2 commits intoopen-telemetry:mainfrom
Closed
fix(confluent-kafka): use PUBLISH operation for producer spans#4435alliasgher wants to merge 2 commits intoopen-telemetry:mainfrom
alliasgher wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
wrap_produce was setting messaging.operation=RECEIVE on producer spans. The correct OTel semantic value for a send/produce operation is PUBLISH. Fixes open-telemetry#4292 Signed-off-by: alliasgher <alliasgher123@gmail.com>
alliasgher
force-pushed
the
fix-confluent-kafka-produce-operation
branch
from
11e1867 to
527ae8a
Compare
Signed-off-by: Ali <alliasgher123@gmail.com>
Member
|
This will conflict with #4423 where I suggested the same fix as part of other work. I see you did it there, so going to close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Producer spans in the Confluent Kafka instrumentation used
CREATEas the messaging operation name. The semantic conventions definePUBLISHfor message send operations. UsePUBLISHso the span'smessaging.operation.nameattribute follows the spec.Fixes #4418
Type of change
Checklist
Unreleased / Fixed